BitPackedArray::scalar_at #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwwmanning
changed the title
|
depends on #179 |
lwwmanning
force-pushed
the
wm/bp-scalar-at
branch
from
9dcc6c0
to
cfb5136
Compare
lwwmanning
force-pushed
the
wm/bp-scalar-at
branch
from
cfb5136
to
fe826a2
Compare
gatesn
previously requested changes
Apr 2, 2024
|
benchmark results at commit e88374f on my MacBook Air M2: ~/g/vortex ❯❯❯ cargo bench --bench bitpacking
Compiling vortex-fastlanes v0.1.0 (/Users/will/git/vortex/vortex-fastlanes)
Finished `bench` profile [optimized] target(s) in 1.83s
Running benches/bitpacking.rs (target/release/deps/bitpacking-274b666c83950221)
Gnuplot not found, using plotters backend
bitpack_1M time: [55.673 µs 55.768 µs 55.883 µs]
Found 13 outliers among 100 measurements (13.00%)
11 (11.00%) high mild
2 (2.00%) high severe
unpack_1M time: [224.61 µs 240.60 µs 258.08 µs]
Found 11 outliers among 100 measurements (11.00%)
6 (6.00%) high mild
5 (5.00%) high severe
unpack_1M_singles time: [2.2627 ms 2.2864 ms 2.3125 ms]
Found 13 outliers among 100 measurements (13.00%)
8 (8.00%) high mild
5 (5.00%) high severe
unpack_1024 time: [43.631 ns 43.774 ns 43.928 ns]
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
unpack_single time: [4.9211 ns 4.9358 ns 4.9515 ns]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild |
gatesn
approved these changes
Apr 3, 2024
robert3005
reviewed
Apr 3, 2024
Comment on lines
+38
to
+49
| fn scalar_at(&self, index: usize) -> VortexResult<Scalar> { | ||
| if index >= self.len() { | ||
| return Err(vortex_err!(OutOfBounds:index, 0, self.len())); | ||
| } | ||
| if self.bit_width() == 0 { | ||
| let ptype = self.dtype().try_into()?; | ||
| match_each_integer_ptype!(&ptype, |$P| { | ||
| return Ok(Scalar::from(0 as $P)); | ||
| }) | ||
| } | ||
| unpack_single(self, index) | ||
| } |
There was a problem hiding this comment.
This needs to take patches into account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.